feat(select): add Neon select theme#354
Merged
Merged
Conversation
|
@devthedevil is attempting to deploy a commit to the younis' projects Team on Vercel. A member of the Team first needs to authorize it. |
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
younisdev
approved these changes
Jul 9, 2026
Owner
|
@devthedevil Great work! Thanks for the contribution! Merging this now and adding you to the contributors list. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Ports the global
Neontheme (already used by the modal component) to the select component's theme registry, per #351.Change
src/components/select/dependencies/themes.json: added aNeonentry (dyvix-select-neon/dyvix-select-input-neon/dyvix-select-dropdown-neon,default-animation: pulse— matching modal's Neon animation).src/components/select/dependencies/style/themes.css: added the corresponding.dyvix-select-neon .dyvix-select-input-neonand.dyvix-select-neon .dyvix-select-dropdown-neonrule blocks (base/hover/focus/placeholder for the input, base/li/li:hover/scrollbar for the dropdown), following the same structure as the existing Lens/Industrial/Ember select themes and reusing modal's Neon color palette (cyan-to-magenta radial gradient, magenta glow shadow).Testing
themes.jsonis valid JSON and the new theme object matches the shape of existing entries..dyvix-select-{theme} .dyvix-select-input-{theme}/.dyvix-select-{theme} .dyvix-select-dropdown-{theme}) used by every other select theme, sodev-engine/scripts/check-themes.jswill now detectNeonas present for theselectcomponent.DYVIX_GLOBAL_THEME.NEONalready exists insrc/constants.js(auto-generated, consumed by modal), so no changes were needed there.Closes #351